Skip to content

Comments

Fix typo on product details causing Validation error. #18522

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
V8MediaUK:validation-fixes
Oct 16, 2018
Merged

Fix typo on product details causing Validation error. #18522
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
V8MediaUK:validation-fixes

Conversation

@BezV8
Copy link
Contributor

@BezV8 BezV8 commented Oct 11, 2018

Description

Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Navigate to the view page of any product.
  2. Check the code on the W3C html validator.
  3. Currently product pages return a "Attribute aria-labeledby not allowed on element div at this point." error as there is a typo in app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

BezV8 and others added 2 commits October 11, 2018 08:57
@BezV8
Merge pull request #2 from magento/2.3-develop
25b40f5 
Sync to magento
@BezV8
Fix typo on product details causing Validation error.
1e41ee9 
Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 11, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nuzil nuzil assigned nuzil and unassigned nuzil Oct 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 11, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 11, 2018

@BezV8 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@nuzil nuzil self-requested a review October 11, 2018 12:12
nuzil
nuzil approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 11, 2018

Hi @nuzil, thank you for the review.
ENGCOM-3162 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 5bd5e4d into magento:2.3-develop Oct 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 16, 2018
ENGCOM-3162: Fix typo on product details causing Validation error. #1…
936f258 
…8522
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 16, 2018

Hi @BezV8. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@gelanivishal gelanivishal mentioned this pull request Oct 16, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nuzil nuzil nuzil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nuzil nuzil

Labels

Area: Frontend Component: Catalog Component: Checkout Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@BezV8 @magento-cicd2 @magento-engcom-team @nuzil